This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use substrate codec for network messages #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
approved these changes
Jul 16, 2018
substrate/network/src/protocol.rs
Outdated
| Some(m) => m, | ||
| None => { | ||
| trace!(target: "sync", "Invalid packet from {}", peer_id); | ||
| io.disable_peer(peer_id, &format!("Peer sent us a packet with invalid format")); |
There was a problem hiding this comment.
looks like there is no need in format! anymore
gavofyork
added
A8-looksgood
and removed
A0-please_review
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
Connect rpc port 9933 failed if polkadot startup without --rpc-external
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* Add cli arguments to configure trace_filter * Add threshold * fmt * Fix TraceFilterCache arg order * Add test for `ethapi_trace_max_count` default (500) * Prettier Co-authored-by: tgmichel <telmo@purestake.com>
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
* Update chainpool/substrate to 6244ecd * remove panic in service start for get pub key from storage * Update chainpool/substrate to fe056d3 * promote runtime log print * Filter these have set up trustee based on the candidates of validators (paritytech#334) Close paritytech#333 * update version * 2 sessions_per_era for now
liuchengxu
added a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
Add Subspace Telemetry
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
…#333) * add test-runtime crate to dynamically obtain metadata/node_runtime for tests * cargo fmt * Download substrate prior to cargo calls (hopefully) * add README explaining test-runtime * Fix CI, fmt and clippy * more clippy * tweak test-node readme * fmt the clippied * A little tidy up in build.rs * use ureq and raw string * Don't export unnecessary metadata * async_std/RpcClient/bytes instead of ureq/Value/hex * newline * document try_from_url error unwrap
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #277
Closes #265
Closes #156